Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore all node_modules #31

Merged
merged 1 commit into from Feb 23, 2018
Merged

Conversation

Raigen
Copy link
Contributor

@Raigen Raigen commented Feb 23, 2018

Ignore all occurrences of node_modules in possible subdirectories.

Fixes #27

Copy link
Member

@hiroppy hiroppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! looks nice:)

@existentialism
Copy link
Member

@Raigen Thanks for the PR! Can you also change: https://github.com/babel/babel-upgrade/blob/master/src/index.js#L58?

Ignore all occurrences of node_modules in possible subdirectories.
@Raigen
Copy link
Contributor Author

Raigen commented Feb 23, 2018

@existentialism Done!

@hzoo
Copy link
Member

hzoo commented Feb 23, 2018

lol I don't know how to use globs I guess? 👍

I am curious about this option though https://github.com/sindresorhus/globby#gitignore - would turning this on be the same affect? does anyone want to test that?

Copy link
Member

@existentialism existentialism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can land this and deal with .gitignore stuff separately?

@hzoo
Copy link
Member

hzoo commented Feb 23, 2018

and we should figure out a test for this

@hzoo hzoo merged commit 9b9739b into babel:master Feb 23, 2018
@hzoo hzoo added the bug Something isn't working label Feb 23, 2018
@hzoo
Copy link
Member

hzoo commented Feb 23, 2018

Ok made #32

@Raigen Raigen deleted the ignore_all_node_modules branch February 24, 2018 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants