Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verifies that the installed dependency is less than expected #98

Merged
merged 3 commits into from
Oct 16, 2018

Conversation

emersonlaurentino
Copy link
Contributor

closes #66

@suchipi
Copy link
Member

suchipi commented Oct 15, 2018

Could you add a test?

@emersonlaurentino
Copy link
Contributor Author

@suchipi Yes, of course.

@emersonlaurentino
Copy link
Contributor Author

hey @suchipi, I'm having the following problem:

ps.: this persists in master

   writes when --write is passed

    expect(jest.fn()).toBeCalled()
    
    Expected mock function to have been called.

      27 | 
      28 |   await writePackageJSON({ write: true });
    > 29 |   expect(writeJsonFile).toBeCalled();
      30 |   writeJsonFile.mockReset();
      31 | 
      32 |   await writeBabelRC("./fixtures/babelrc.json5", { write: true });

Do you have any idea how to solve it?

@emersonlaurentino
Copy link
Contributor Author

I was having an unusual problem, when I installed the dependencies with npm and tried to run the test with yarn, it removed all my dependencies from the package.json

@emersonlaurentino
Copy link
Contributor Author

done @suchipi

Copy link
Member

@suchipi suchipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you!

@suchipi suchipi merged commit 73d855c into babel:master Oct 16, 2018
@emersonlaurentino emersonlaurentino deleted the fix-downgraded branch October 16, 2018 21:14
@hzoo
Copy link
Member

hzoo commented Oct 17, 2018

nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

babel-upgrade downgraded babel-loader
3 participants