fix: Correctly generate TSMappedType (#16394)

babel · Apr 1, 2024 · 22725e9 · 22725e9
1 parent 48a3e19
commit 22725e9
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 7 deletions.
diff --git a/packages/babel-generator/src/generators/typescript.ts b/packages/babel-generator/src/generators/typescript.ts
@@ -414,7 +414,7 @@ export function TSIndexedAccessType(
 }
 
 export function TSMappedType(this: Printer, node: t.TSMappedType) {
-  const { nameType, optional, readonly, typeParameter } = node;
+  const { nameType, optional, readonly, typeParameter, typeAnnotation } = node;
   this.token("{");
   this.space();
   if (readonly) {
@@ -443,13 +443,15 @@ export function TSMappedType(this: Printer, node: t.TSMappedType) {
 
   this.token("]");
 
-  if (optional) {
-    tokenIfPlusMinus(this, optional);
-    this.token("?");
+  if (typeAnnotation) {
+    if (optional) {
+      tokenIfPlusMinus(this, optional);
+      this.token("?");
+    }
+    this.token(":");
+    this.space();
+    this.print(typeAnnotation, node);
   }
-  this.token(":");
-  this.space();
-  this.print(node.typeAnnotation, node);
   this.space();
   this.token("}");
 }

diff --git a/packages/babel-generator/test/fixtures/typescript/mapped-type/input.ts b/packages/babel-generator/test/fixtures/typescript/mapped-type/input.ts
@@ -0,0 +1 @@
+type Bar = { [key in Foo] };
diff --git a/packages/babel-generator/test/fixtures/typescript/mapped-type/output.js b/packages/babel-generator/test/fixtures/typescript/mapped-type/output.js
@@ -0,0 +1 @@
+type Bar = { [key in Foo] };