fix: Default export for duplicate names (#15736)

babel · Jul 3, 2023 · 41dea06 · 41dea06
1 parent 134aa17
commit 41dea06
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 5 deletions.
diff --git a/packages/babel-helper-split-export-declaration/src/index.ts b/packages/babel-helper-split-export-declaration/src/index.ts
@@ -27,6 +27,8 @@ export default function splitExportDeclaration(
     const declaration = exportDeclaration.get("declaration");
     const standaloneDeclaration =
       declaration.isFunctionDeclaration() || declaration.isClassDeclaration();
+    const exportExpr =
+      declaration.isFunctionExpression() || declaration.isClassExpression();
 
     const scope = declaration.isScope()
       ? declaration.scope.parent
@@ -41,13 +43,13 @@ export default function splitExportDeclaration(
 
       id = scope.generateUidIdentifier("default");
 
-      if (
-        standaloneDeclaration ||
-        declaration.isFunctionExpression() ||
-        declaration.isClassExpression()
-      ) {
+      if (standaloneDeclaration || exportExpr) {
         declaration.node.id = cloneNode(id);
       }
+    } else if (exportExpr && scope.hasBinding(id.name)) {
+      needBindingRegistration = true;
+
+      id = scope.generateUidIdentifier(id.name);
     }
 
     const updatedDeclaration = standaloneDeclaration

diff --git a/...plugin-transform-modules-commonjs/test/fixtures/misc/export-expr-with-same-name/input.mjs b/...plugin-transform-modules-commonjs/test/fixtures/misc/export-expr-with-same-name/input.mjs
@@ -0,0 +1,4 @@
+import someFunction from './b';
+
+export default (function someFunction () {
+});
diff --git a/...plugin-transform-modules-commonjs/test/fixtures/misc/export-expr-with-same-name/output.js b/...plugin-transform-modules-commonjs/test/fixtures/misc/export-expr-with-same-name/output.js
@@ -0,0 +1,10 @@
+"use strict";
+
+Object.defineProperty(exports, "__esModule", {
+  value: true
+});
+exports.default = void 0;
+var _b = _interopRequireDefault(require("./b"));
+function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
+var _someFunction = function someFunction() {};
+exports.default = _someFunction;