Fix path.evaluate for references before declarations (#4875)

babel · Nov 21, 2016 · 7e02027 · 7e02027
1 parent 3a27f49
commit 7e02027
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/packages/babel-traverse/src/path/evaluation.js b/packages/babel-traverse/src/path/evaluation.js
@@ -173,6 +173,10 @@ export function evaluate(): { confident: boolean; value: any } {
         return deopt(binding.path);
       }
 
+      if (binding && path.node.start < binding.path.node.end) {
+        return deopt(binding.path);
+      }
+
       if (binding && binding.hasValue) {
         return binding.value;
       } else {

diff --git a/packages/babel-traverse/test/evaluation.js b/packages/babel-traverse/test/evaluation.js
@@ -86,4 +86,16 @@ describe("evaluation", function () {
       false
     );
   });
+
+  it("should deopt ids that are referenced before the bindings", function () {
+    assert.strictEqual(
+      getPath("let x = y + 5; let y = 5;").get("body.0.declarations.0.init").evaluate().confident,
+      false
+    );
+    assert.strictEqual(
+      getPath("if (typeof x === 'undefined') var x = {}")
+        .get("body.0.test").evaluate().confident,
+      false
+    );
+  });
 });