address review comments

babel · Jun 30, 2020 · aa31eb3 · aa31eb3
1 parent 85acb34
commit aa31eb3
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 7 deletions.
diff --git a/packages/babel-plugin-transform-runtime/src/index.js b/packages/babel-plugin-transform-runtime/src/index.js
@@ -36,7 +36,10 @@ export default declare((api, options, dirname) => {
 
   if (corejsVersion === 2) {
     throw new Error(
-      "Since Babel 8, the core-js 2 support has been dropped. Please use 'corejs: 3'.",
+      `Since Babel 8, the core-js 2 support has been dropped. Please use 'corejs: 3'.
+- If you really want to use obsolete core-js@2, please install \`babel-plugin-polyfill-corejs2\` and add to the "plugins" config
+  npm install --save-dev babel-plugin-polyfill-corejs2
+  yarn add --dev babel-plugin-polyfill-corejs2`,
     );
   }
 

diff --git a/packages/babel-preset-env/src/normalize-options.js b/packages/babel-preset-env/src/normalize-options.js
@@ -249,7 +249,10 @@ export function normalizeCoreJSOption(
       );
     } else if (version.major === 2) {
       throw new Error(
-        `Since Babel 8, the core-js@2 support has been dropped. Please use \`corejs: "3.6"\`.`,
+        `Since Babel 8, the core-js@2 support has been dropped. Please use \`corejs: "3.6"\`.
+- If you really want to use obsolete core-js@2, please install \`babel-plugin-polyfill-corejs2\` and add to the "plugins" config
+  npm install --save-dev babel-plugin-polyfill-corejs2
+  yarn add --dev babel-plugin-polyfill-corejs2`,
       );
     }
   }

diff --git a/packages/babel-preset-env/test/normalize-options.spec.js b/packages/babel-preset-env/test/normalize-options.spec.js
@@ -90,11 +90,11 @@ describe("normalize-options", () => {
     it("should throw removed option if corejs version is 2", () => {
       [2, 2.1].forEach(corejs => {
         ["entry", "usage"].forEach(useBuiltIns => {
-          expect(() =>
-            normalizeOptions.default({ useBuiltIns, corejs }),
-          ).toThrowError(
-            /Since Babel 8, the core-js@2 support has been dropped. Please use `corejs: "3.6"`/,
-          );
+          expect(() => normalizeOptions.default({ useBuiltIns, corejs }))
+            .toThrowError(`Since Babel 8, the core-js@2 support has been dropped. Please use \`corejs: "3.6"\`.
+- If you really want to use obsolete core-js@2, please install \`babel-plugin-polyfill-corejs2\` and add to the "plugins" config
+  npm install --save-dev babel-plugin-polyfill-corejs2
+  yarn add --dev babel-plugin-polyfill-corejs2`);
         });
       });
     });