Breaking: parserOpts.createImportExpressions defaults to true (#16114)

* breaking: createImportExpressions defaults to true * enable createImportExpressions in the build config
babel · Nov 24, 2023 · bd98d8f · bd98d8f
1 parent 1e9a1d4
commit bd98d8f
Show file tree

Hide file tree

Showing 10 changed files with 49 additions and 3 deletions.
diff --git a/babel.config.js b/babel.config.js
@@ -171,6 +171,9 @@ module.exports = function (api) {
     ]
       .filter(Boolean)
       .map(normalize),
+    parserOpts: {
+      createImportExpressions: true,
+    },
     presets: [
       // presets are applied from right to left
       ["@babel/env", envOpts],

diff --git a/packages/babel-parser/src/options.ts b/packages/babel-parser/src/options.ts
@@ -71,7 +71,7 @@ export const defaultOptions: Options = {
   tokens: false,
   // Whether to create ImportExpression AST nodes (if false
   // `import(foo)` will be parsed as CallExpression(Import, [Identifier(foo)])
-  createImportExpressions: false,
+  createImportExpressions: process.env.BABEL_8_BREAKING ? true : false,
   // Whether to create ParenthesizedExpression AST nodes (if false
   // the parser sets extra.parenthesized on the expression nodes instead).
   createParenthesizedExpressions: false,

diff --git a/...mport-no-createImportExpressions/input.js → ...rt-createImportExpressions-false/input.js b/...mport-no-createImportExpressions/input.js → ...rt-createImportExpressions-false/input.js
diff --git a/...perimental/source-phase-imports/dynamic-import-createImportExpressions-false/options.json b/...perimental/source-phase-imports/dynamic-import-createImportExpressions-false/options.json
@@ -0,0 +1,5 @@
+{
+  "plugins": ["sourcePhaseImports"],
+  "createImportExpressions": false,
+  "throws": "'import.source(...)' can only be parsed when using the 'createImportExpressions' option. (1:7)"
+}
diff --git a/...es/experimental/source-phase-imports/dynamic-import-createImportExpressions-true/input.js b/...es/experimental/source-phase-imports/dynamic-import-createImportExpressions-true/input.js
@@ -0,0 +1 @@
+import.source("foo");
diff --git a/...xperimental/source-phase-imports/dynamic-import-createImportExpressions-true/options.json b/...xperimental/source-phase-imports/dynamic-import-createImportExpressions-true/options.json
@@ -0,0 +1,4 @@
+{
+  "plugins": ["sourcePhaseImports"],
+  "createImportExpressions": true
+}
diff --git a/...experimental/source-phase-imports/dynamic-import-createImportExpressions-true/output.json b/...experimental/source-phase-imports/dynamic-import-createImportExpressions-true/output.json
@@ -0,0 +1,31 @@
+{
+  "type": "File",
+  "start":0,"end":21,"loc":{"start":{"line":1,"column":0,"index":0},"end":{"line":1,"column":21,"index":21}},
+  "program": {
+    "type": "Program",
+    "start":0,"end":21,"loc":{"start":{"line":1,"column":0,"index":0},"end":{"line":1,"column":21,"index":21}},
+    "sourceType": "module",
+    "interpreter": null,
+    "body": [
+      {
+        "type": "ExpressionStatement",
+        "start":0,"end":21,"loc":{"start":{"line":1,"column":0,"index":0},"end":{"line":1,"column":21,"index":21}},
+        "expression": {
+          "type": "ImportExpression",
+          "start":0,"end":20,"loc":{"start":{"line":1,"column":0,"index":0},"end":{"line":1,"column":20,"index":20}},
+          "phase": "source",
+          "source": {
+            "type": "StringLiteral",
+            "start":14,"end":19,"loc":{"start":{"line":1,"column":14,"index":14},"end":{"line":1,"column":19,"index":19}},
+            "extra": {
+              "rawValue": "foo",
+              "raw": "\"foo\""
+            },
+            "value": "foo"
+          }
+        }
+      }
+    ],
+    "directives": []
+  }
+}
diff --git a/...perimental/source-phase-imports/dynamic-import-no-createImportExpressions-babel7/input.js b/...perimental/source-phase-imports/dynamic-import-no-createImportExpressions-babel7/input.js
@@ -0,0 +1 @@
+import.source("foo");
diff --git a/...t-no-createImportExpressions/options.json → ...eateImportExpressions-babel7/options.json b/...t-no-createImportExpressions/options.json → ...eateImportExpressions-babel7/options.json
@@ -1,4 +1,5 @@
 {
+  "BABEL_8_BREAKING": false,
   "plugins": ["sourcePhaseImports"],
   "throws": "'import.source(...)' can only be parsed when using the 'createImportExpressions' option. (1:7)"
 }
diff --git a/.../babel-parser/test/fixtures/experimental/source-phase-imports/dynamic-import/options.json b/.../babel-parser/test/fixtures/experimental/source-phase-imports/dynamic-import/options.json
@@ -1,4 +1,4 @@
 {
-  "plugins": ["sourcePhaseImports"],
-  "createImportExpressions": true
+  "BABEL_8_BREAKING": true,
+  "plugins": ["sourcePhaseImports"]
 }