Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Babel-minify throws cannot set property inList of [object Object] which has only a getter #10654

Closed
JLHwung opened this issue Nov 5, 2019 · 2 comments · Fixed by #10656
Closed
Labels
i: bug i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue

Comments

@JLHwung
Copy link
Contributor

JLHwung commented Nov 5, 2019

Bug Report

Current Behavior
Babel-minify will throw on @babel/traverse 7.7

Input Code

Expected behavior/code
It should not throw

Environment

  • Babel version(s): 7.7.0
  • How you are using Babel: REPL

Possible Solution
Add a setter of inList which will set listKey to null when false is passed.

** Additional Context **
This regression was introduced in #10480.

@babel-bot
Copy link
Collaborator

Hey @JLHwung! We really appreciate you taking the time to report an issue. The collaborators on this project attempt to help as many people as possible, but we're a limited number of volunteers, so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack community that typically always has someone willing to help. You can sign-up here for an invite."

@JLHwung
Copy link
Contributor Author

JLHwung commented Nov 6, 2019

Fixed in 7.7.2.

benlavalley pushed a commit to benlavalley/babel that referenced this issue Nov 17, 2019
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Feb 6, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
i: bug i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants