New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move @babel/helper-optimise-call-expression to ts #12411
move @babel/helper-optimise-call-expression to ts #12411
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/33694/ |
export default function optimiseCallExpression( | ||
callee: Expression, | ||
thisNode: Expression, | ||
args: Readonly<Array<Expression | SpreadElement>>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: Does TS check that the JSDoc comment types are correct, when using type annotations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so. The JSDoc is checked only when TypeScript is checking JavaScript files: https://www.typescriptlang.org/docs/handbook/jsdoc-supported-types.html
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 34c189d:
|
f8f2cb5
to
34c189d
Compare
* move @babel/helper-optimise-call-expression to ts * chore: add flow interface
We have type checking for this library, cheers.