move @babel/helper-optimise-call-expression to ts (babel#12411)

* move @babel/helper-optimise-call-expression to ts * chore: add flow interface
nicolo-ribaudo · Dec 2, 2020 · a26f4ef · a26f4ef
1 parent f4cf168
commit a26f4ef
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 7 deletions.
diff --git a/lib/babel-packages.js.flow b/lib/babel-packages.js.flow
@@ -34,3 +34,12 @@ declare module "@babel/template" {
     program: Program,
   };
 }
+
+declare module "@babel/helper-optimise-call-expression" {
+  declare export default function optimiseCallExpression(
+    callee: BabelNodeExpression,
+    thisNode: BabelNodeExpression,
+    args: $Readonly<Array<BabelNodeExpression | BabelNodeSpreadElement>>,
+    optional: boolean
+  ): BabelNodeCallExpression | BabelNodeOptionalCallExpression;
+}
diff --git a/...per-optimise-call-expression/src/index.js → ...per-optimise-call-expression/src/index.ts b/...per-optimise-call-expression/src/index.js → ...per-optimise-call-expression/src/index.ts
@@ -1,20 +1,26 @@
 import * as t from "@babel/types";
+import type {
+  CallExpression,
+  Expression,
+  OptionalCallExpression,
+  SpreadElement,
+} from "@babel/types";
 
 /**
  * A helper function that generates a new call expression with given thisNode.
  It will also optimize `(...arguments)` to `.apply(arguments)`
  *
  * @export
- * @param {Node} callee The callee of call expression
- * @param {Node} thisNode The desired this of call expression
- * @param {Node[]} args The arguments of call expression
+ * @param {Expression} callee The callee of call expression
+ * @param {Expression} thisNode The desired this of call expression
+ * @param {Readonly<Array<Expression | SpreadElement>>} args The arguments of call expression
  * @param {boolean} optional Whether the call expression is optional
  * @returns {CallExpression | OptionalCallExpression} The generated new call expression
  */
-export default function (
-  callee: Node,
-  thisNode: Node,
-  args: Node[],
+export default function optimiseCallExpression(
+  callee: Expression,
+  thisNode: Expression,
+  args: Readonly<Array<Expression | SpreadElement>>,
   optional: boolean,
 ): CallExpression | OptionalCallExpression {
   if (