Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more jsx whitespace issues #165

Closed
monsanto opened this issue Nov 14, 2014 · 1 comment
Closed

more jsx whitespace issues #165

monsanto opened this issue Nov 14, 2014 · 1 comment
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue

Comments

@monsanto
Copy link
Contributor

This PR appears to be the only place JSX whitespace rules are documented.

example 1

<p>foo <a href="test">bar</a> baz</p>
# 6to5  test.jsx
"use strict";

React.createElement("p", null, "foo ", React.createElement("a", {
  href: "test"
}, "bar"), "baz"); # note lack of space before baz
# jsx test.jsx
React.createElement("p", null, "foo ", React.createElement("a", {href: "test"}, "bar"), " baz")

example 2

<p>
    foo
    <a href="test">bar</a>
    baz
</p>
# 6to5 test.jsx    
"use strict";

React.createElement("p", null, "\n    Test\n    ", React.createElement("a", {
  href: "test"
}, "test"), "test\n");
# jsx test.jsx
React.createElement("p", null, 
    "Test", 
    React.createElement("a", {href: "test"}, "test"), 
    "test"
)
@sebmck sebmck added the parser label Nov 15, 2014
sebmck added a commit that referenced this issue Nov 15, 2014
@sebmck sebmck added question and removed question labels Nov 15, 2014
@sebmck sebmck closed this as completed in 424bab9 Nov 15, 2014
@sebmck
Copy link
Contributor

sebmck commented Nov 15, 2014

Thanks! Should be fixed as of 1.12.15

sebmck pushed a commit that referenced this issue Mar 16, 2015
Specifically, you can now require("regenerator/runtime-module") if you
want to access the runtime without relying on the global namespace.

Note that runtime.js is now fully strict-mode-compliant.

Fixes #165.
Fixes #166.
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jan 19, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Development

No branches or pull requests

2 participants