Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source maps stopped populating names in 6to5@1.7.0 #27

Closed
es128 opened this issue Oct 9, 2014 · 1 comment
Closed

Source maps stopped populating names in 6to5@1.7.0 #27

es128 opened this issue Oct 9, 2014 · 1 comment
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue

Comments

@es128
Copy link
Member

es128 commented Oct 9, 2014

Source map from 1.6.0:

{"version":3,"sources":["fixture.js"],"names":["Test"],"mappings":"IAAMA,I;WAAAA,I;;SAAAA,I","file":"fixture.js","sourcesContent":["class Test {}\n"]}

Source map from 1.7.0:

{"version":3,"file":"fixture.js","sources":["fixture.js"],"names":[],"mappings":"IAAM,CAAC,CAAC,CAAC;WAAH,CAAC,CAAC,CAAC;SAAH,CAAC,CAAC,CAAC","sourcesContent":["class Test {}\n"]}

Appears to be a side effect from the switch to recast. Might not be important, but I figured I'd report it.

es128 referenced this issue in es128/grunt-6to5 Oct 9, 2014
The changed behavior to `names` in the sourcemap may be a bug to be reported to 6to5
@sebmck
Copy link
Contributor

sebmck commented Oct 9, 2014

I've added more reliable source map tests with commit d511fc8. Hopefully this catches all future source map issues.

@sebmck sebmck closed this as completed Oct 9, 2014
JacopKane pushed a commit to JacopKane/babel that referenced this issue Jan 11, 2018
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jan 19, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Development

No branches or pull requests

3 participants