New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor transform-classes #7202

Closed
Andarist opened this Issue Jan 11, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@Andarist
Member

Andarist commented Jan 11, 2018

At the moment transform-classes has 2 modes - regular one and loose. The loose mode is extending VanillaTransformer class. It seems to me that this hierarchical structure here is clunky and harder to maintain.

Don't know how others feel, but imho it would be nice to refactor this into a flat structure and reuse code between 2 transforms if possible, but more in a composition manner than with inheritance.

I'd like to have at least 2-3 upvotes from other core team members for this, before anyone starts to work on this.

@babel-bot

This comment has been minimized.

Show comment
Hide comment
@babel-bot

babel-bot Jan 11, 2018

Collaborator

Hey @Andarist! We really appreciate you taking the time to report an issue. The collaborators
on this project attempt to help as many people as possible, but we're a limited number of volunteers,
so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack
community that typically always has someone willing to help. You can sign-up here
for an invite.

Collaborator

babel-bot commented Jan 11, 2018

Hey @Andarist! We really appreciate you taking the time to report an issue. The collaborators
on this project attempt to help as many people as possible, but we're a limited number of volunteers,
so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack
community that typically always has someone willing to help. You can sign-up here
for an invite.

@lock lock bot added the outdated label Jun 20, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Jun 20, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.