Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: custom instOfHandler result should be cast to boolean #10197

Merged
merged 1 commit into from Jul 10, 2019

Conversation

@JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Jul 10, 2019

Q                       A
Fixed Issues? Fixes #10196
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Please refer to #10196 for the background and rationale.

@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented Jul 10, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11099/

@nicolo-ribaudo nicolo-ribaudo merged commit e88a569 into babel:master Jul 10, 2019
4 checks passed
4 checks passed
@babel-bot
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
@codecov
codecov/project 87.57% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Jul 10, 2019

Thanks!

@JLHwung JLHwung deleted the JLHwung:to-boolean-inst-of-handler branch Jul 10, 2019
@lock lock bot added the outdated label Oct 9, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants