Always use sourceFileName instead of sourceFilename.
#10291
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There seems to be some confusion around which of these two is correct within the codebase. This consolidates all instances to be `sourceFileName` since that one had more instances.
hzoo
reviewed
Aug 1, 2019
Co-Authored-By: Henry Zhu <hi@henryzoo.com>
| @@ -26,7 +26,7 @@ export default class Parser extends StatementParser { | |||
| this.inModule = this.options.sourceType === "module"; | |||
| this.scope = new ScopeHandler(this.raise.bind(this), this.inModule); | |||
| this.plugins = pluginsMap(this.options.plugins); | |||
| this.filename = options.sourceFilename; | |||
| this.filename = options.sourceFilename || options.sourceFileName; | |||
There was a problem hiding this comment.
Since the nullish coaleshing proposal is now stage 3, we could enable @babel/plugin-proposal-nullish-coalescing-operator and use options.sourceFilename ?? options.sourceFileName 😎
There was a problem hiding this comment.
It has been enabled on master, you just need to rebase.
xtuc
approved these changes
Aug 5, 2019
|
I'm not sure what should be done about the test failures. Anyone else want to advise? |
|
I'm not sure, maybe try rebasing it 🤔 |
nicolo-ribaudo
added
the
PR: Polish 💅
| @@ -1,5 +1,5 @@ | |||
| type BabelParserOptions = { | |||
| sourceFilename?: string; | |||
| sourceFileName?: string; | |||
There was a problem hiding this comment.
Isn't this a breaking change?
|
Not sure what should be done to make this work, so I'm just going to close it. If someone else wants to pick it up, feel free. |
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be some confusion around which of these two is correct within the codebase. This consolidates all instances to be
sourceFileNamesince that one had more instances.