-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a builder definition including name for tsTypeParameter #10319
Add a builder definition including name for tsTypeParameter #10319
Conversation
@@ -494,7 +494,7 @@ defineType("TSTypeParameterDeclaration", { | |||
}); | |||
|
|||
defineType("TSTypeParameter", { | |||
visitor: ["constraint", "default"], | |||
visitor: ["constraint", "default", "name"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only nodes can be visited, so we can't add name
to visitor
.
You can define builder: ["constraint", "default", "name"],
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CircleCI failure is unrelated
Adds
name
to the visitor field forTSTypeParameter
, this is a required field but since it is not listed here the assert fails rendering the function useless, since it cannot be called with either 2 or 3 arguments.Documentation: I found this when trying to run all the t.* builder functions, but my generation "fails" here because it doesn't look like these arguments are required, they are (which has been corrected in the current master). So I will need to re-run that generation once that fix is available.