-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't allow instance properties transformation on namespace #10372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
reviewed
Aug 30, 2019
JLHwung
added
the
PR: Polish 💅
A type of pull request used for our changelog categories
label
Aug 30, 2019
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11433/ |
Seems something like that also required for the |
@zloirock updated for |
6 tasks
nicolo-ribaudo
approved these changes
Sep 5, 2019
JLHwung
approved these changes
Sep 5, 2019
This was referenced Sep 17, 2019
nicolo-ribaudo
pushed a commit
to babel/babel-polyfills
that referenced
this pull request
Sep 18, 2019
This is a port of babel/babel#10372
This was referenced Oct 3, 2019
This was referenced Nov 28, 2019
lock
bot
added
the
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
label
Dec 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
pkg: preset-env
PR: Polish 💅
A type of pull request used for our changelog categories
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properties transformation on namespace is unnecessary and will break webpack's Tree-Shaking.
Input:
Before output:
After output: