Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo #10409

Merged
merged 1 commit into from
Sep 9, 2019
Merged

Fix typo #10409

merged 1 commit into from
Sep 9, 2019

Conversation

FND
Copy link
Contributor

@FND FND commented Sep 7, 2019

s/compliancy/compliancy/g - seems both correct and consistent with more recent occurrences

@FND
Fix typo
a3e8b73 
s/compliancy/compliancy/g - seems both correct and consistent with more
recent occurrences
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11511/

@nicolo-ribaudo
Copy link
Member

Could you also update it in the first few lines of https://github.com/babel/babel/blob/master/CHANGELOG.md? The rest of the file is automatically generated

@FND
Copy link
Contributor Author

FND commented Sep 9, 2019

I'm not sure what you mean, @nicolo-ribaudo: My patch should include that already (see
https://github.com/FND/babel/blob/compliance-typo/CHANGELOG.md)?

FWIW, I'd used git grep -il compliancy | xargs sed -i -e "s/ompliancy/ompliance/g" to make sure I didn't miss anything.

nicolo-ribaudo
nicolo-ribaudo approved these changes Sep 9, 2019
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, for some reason I only saw the first file initially

@nicolo-ribaudo nicolo-ribaudo merged commit daf25af into babel:master Sep 9, 2019
@FND FND deleted the compliance-typo branch September 9, 2019 07:28
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 9, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FND @babel-bot @nicolo-ribaudo