Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect trace position in fixture runner #10566

Conversation

@JLHwung
Copy link
Contributor

JLHwung commented Oct 16, 2019

Q                       A
Fixed Issues? Incorrect callsite position when error is thrown at the first line in the exec fixture.
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

In this PR we place the fixture code at the second line and add lineOffset to make sure the error stack position is correct.

You can check this build to see that the fixture error stack is incorrect when error is thrown at the first line.

@JLHwung JLHwung force-pushed the JLHwung:incorrect-trace-position-in-fixture-runner branch from 9875daf to 80069c9 Oct 16, 2019
@nicolo-ribaudo nicolo-ribaudo merged commit e94da0d into babel:master Dec 4, 2019
3 checks passed
3 checks passed
Travis CI - Pull Request Build Passed
Details
buildsize No change
Details
ci/circleci: build Your tests passed on CircleCI!
Details
@nicolo-ribaudo nicolo-ribaudo deleted the JLHwung:incorrect-trace-position-in-fixture-runner branch Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.