Remove import bindings after rewriting live references #10640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: Internal 🏠
JLHwung
reviewed
Nov 4, 2019
| // redeclared in this scope | ||
| if (rootBinding !== localBinding) return; | ||
| if (!isSameBinding(scope, path.scope, localName)) return; |
There was a problem hiding this comment.
Consider add it to a scope method, such as
scope.hasSameBinding(localName, otherScope)because the // redeclared in this scope check is also used in helper-simple-access and transform-modules-commonjs.
There was a problem hiding this comment.
Then it wouldn't work with @babel/core <= 7.6.0. Let's defer this PR to Babel 8 since it's not urgent.
There was a problem hiding this comment.
🤔Doesn't uncommenting !!binding cause it fail with @babel/core <= 7.6.0?
Let's defer this PR to Babel 8 since it's not urgent.
Yup.
There was a problem hiding this comment.
Also relying on scope.hasSameBinding, since in older versions it's undefined.
nicolo-ribaudo
force-pushed
the
internal-rewrite-live-references-before-removing-bindings
branch
from
4873b24
to
19141ac
Compare
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/50585/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #10628 (comment)
This PR doesn't have any tests because it's just an optimization (before getting the rhs binding, it checks if the lhs one is defined).