Clean up @babel/eslint-plugin #10756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaicataldo
force-pushed
the
update-babel-eslint-plugin
branch
2 times, most recently
from
351d5ca
to
8408c94
Compare
kaicataldo
force-pushed
the
update-babel-eslint-plugin
branch
from
8408c94
to
74a5dec
Compare
nicolo-ribaudo
approved these changes
Nov 23, 2019
JLHwung
reviewed
Nov 25, 2019
JLHwung
reviewed
Nov 25, 2019
JLHwung
reviewed
Nov 25, 2019
Co-Authored-By: Huáng Jùnliàng <jlhwung@gmail.com>
|
Thanks for the review! Ready for re-review. |
existentialism
approved these changes
Nov 25, 2019
JLHwung
reviewed
Nov 25, 2019
| "babel/semi": 1, | ||
| "babel/no-unused-expressions": 1, | ||
| "babel/valid-typeof": 1 | ||
| "babel/new-cap": "error", |
There was a problem hiding this comment.
The rule name should be prefixed by the plugin name: i.e. @babel/eslint-plugin/new-cap. Could you check if @babel/new-cap works?
There was a problem hiding this comment.
Sure - my intention isn't to update everything here, but to just get a baseline so I can start working. I was imaging that a lot of this README is going to be changed anyway, since I'm hoping to remove the deprecated rules and rethink how we keep this up-to-date with ESLint core rules.
JLHwung
approved these changes
Nov 25, 2019
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preliminary housekeeping tasks for @babel/eslint-plugin.