Update core-js-compat #10795
Merged
Update core-js-compat #10795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolo-ribaudo
commented
Dec 2, 2019
nicolo-ribaudo
commented
| Q | A |
|---|---|
| Fixed Issues? | Closes #10794 |
| Patch: Bug Fix? | Fixes CircleCI builds |
| Tests Added + Pass? | Yes |
| Documentation PR Link | |
| Any Dependency Changes? | Update |
| License | MIT |
existentialism
approved these changes
Dec 2, 2019
|
Ok, this is failing because of npm/cli#545 |
JLHwung
reviewed
Dec 2, 2019
yarn.lock
Outdated
| version "3.2.1" | ||
| resolved "https://registry.yarnpkg.com/core-js-compat/-/core-js-compat-3.2.1.tgz#0cbdbc2e386e8e00d3b85dc81c848effec5b8150" | ||
| integrity sha512-MwPZle5CF9dEaMYdDeWm73ao/IflDH+FjeJCWEADcEgFSE9TLimFKwJsfmkwzI8eC0Aj0mgvMDjeQjrElkz4/A== | ||
| version "3.4.6" |
There was a problem hiding this comment.
🤔I guess here is the culprit: For some reason (CDN cache?) 3.4.7 is not installed.
There was a problem hiding this comment.
Could you re-run yarn upgrade so the lockfile can be updated? (Also Circle CI cache can be thus reset again)
JLHwung
approved these changes
Dec 2, 2019
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.