Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove redundant contextDescription empty check #11219

Merged
merged 1 commit into from
Mar 5, 2020
Merged

refactor: remove redundant contextDescription empty check #11219

merged 1 commit into from
Mar 5, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Mar 5, 2020

Q                       A
License MIT

This PR removes redundant contextDescription empty checks because

  1. The checkLVal signature denotes contextDescription to be required parameter. Passing undefined or null to checkLVal should result in a flow error.
  2. I manually checked all checkLVal usage, none of them passing empty contextDescription
  3. No test is broken from this change

@JLHwung JLHwung added PR: Internal 🏠 A type of pull request used for our changelog categories pkg: parser labels Mar 5, 2020
@JLHwung JLHwung force-pushed the remove-check-lval-context-description-empty-check branch from 3b62772 to 4dab86a Compare March 5, 2020 20:02
@JLHwung JLHwung merged commit e297e40 into babel:master Mar 5, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the remove-check-lval-context-description-empty-check branch March 5, 2020 21:20
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jun 5, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JLHwung @existentialism @nicolo-ribaudo