Add support for Unicode 13 in regexps (update regexpu-core)
#11244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolo-ribaudo
commented
Mar 11, 2020
nicolo-ribaudo
commented
| Q | A |
|---|---|
| Fixed Issues? | Fixes #11243 |
| Patch: Bug Fix? | |
| Major: Breaking Change? | |
| Minor: New Feature? | Yes |
| Tests Added + Pass? | Yes |
| Documentation PR Link | |
| Any Dependency Changes? | Yes |
| License | MIT |
nicolo-ribaudo
added
PR: New Feature 🚀
existentialism
approved these changes
Mar 11, 2020
JLHwung
reviewed
Mar 11, 2020
| @@ -1,2 +1,2 @@ | |||
| var a = /[\u3400-\u4DB5\u4E00-\u9FEF\uFA0E\uFA0F\uFA11\uFA13\uFA14\uFA1F\uFA21\uFA23\uFA24\uFA27-\uFA29\u{20000}-\u{2A6D6}\u{2A700}-\u{2B734}\u{2B740}-\u{2B81D}\u{2B820}-\u{2CEA1}\u{2CEB0}-\u{2EBE0}][\0-\t\x0B\f\x0E-\u2027\u202A-\u{10FFFF}]/u; | |||
There was a problem hiding this comment.
The current master CI is failing due to recent regexpu-core update:
https://github.com/babel/babel/pull/11242/checks?check_run_id=501623515#step:5:785
Any chance to separate fixture update and merge it in a patch release?
There was a problem hiding this comment.
Well, we could directly merge this in a patch I think. Since we use ^ for the dependency range, even old Babel versions already have support for Unicode 13.
mathiasbynens
approved these changes
Mar 11, 2020
|
Given the 👍s for #11244 (comment), I'm merging this. |
|
Thanks for tackling this so quickly! |
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.