Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Babel compiled using an old version of `@babel/core` #11319

Merged
merged 2 commits into from Mar 23, 2020

Conversation

@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Mar 23, 2020

Q                       A
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This should catch regressions where we use a new helper without a fallback
for older versions, or when we use a new @babel/traverse method.

This should catch regressions where we use a new helper without a fallback
for older versions, or when we use a new @babel/traverse method.
#==============================================================================#

startLocalRegistry "$PWD"/scripts/integration-tests/verdaccio-config.yml
yarn upgrade --scope @babel

This comment has been minimized.

Copy link
@JLHwung

JLHwung Mar 23, 2020

Contributor

Is yarn upgrade working again in our repo?

This comment has been minimized.

Copy link
@nicolo-ribaudo

nicolo-ribaudo Mar 23, 2020

Author Member

Oh ignore me, it doesn't work. According to the docs, yarn upgrade doesn't modify package.json if it's not needed, but it still updates the dependencies. You can see that yarn.lock changes after running this command.

This comment has been minimized.

Copy link
@JLHwung

JLHwung Mar 23, 2020

Contributor

We have replaced yarn upgrade by an ad-hoc script in #11021 due to yarnpkg/yarn#7797. I am not sure if that issue has been fixed or it affects only yarn upgrade-interactive so yarn upgrade is good.

This comment has been minimized.

Copy link
@nicolo-ribaudo

nicolo-ribaudo Mar 23, 2020

Author Member

It doesn't give problems here because we are not using yarn workspaces.
In yarn 2 it's probably fixed since it is a complete rewrite, but if it's not I can work around it in whichever of those two PRs (this one or yarn 2) gets merged last.

@nicolo-ribaudo

This comment has been minimized.

Copy link
Member Author

nicolo-ribaudo commented Mar 23, 2020

Thanks for all the reviews and thanks to me for the PR!

I didn't enable the test 🤣

@nicolo-ribaudo nicolo-ribaudo force-pushed the nicolo-ribaudo:e2e-old-babel branch from 171b563 to 6f855dc Mar 23, 2020
@existentialism

This comment has been minimized.

Copy link
Member

existentialism commented Mar 23, 2020

Tests can't fail if they don't run!

@nicolo-ribaudo nicolo-ribaudo merged commit 9b976b2 into babel:master Mar 23, 2020
5 of 6 checks passed
5 of 6 checks passed
build (13.x)
Details
test262 Workflow: test262
Details
Travis CI - Pull Request Build Passed
Details
build-standalone Workflow: build-standalone
Details
codecov/project 91.75% (target 90.00%)
Details
e2e Workflow: e2e
Details
@nicolo-ribaudo nicolo-ribaudo deleted the nicolo-ribaudo:e2e-old-babel branch Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.