-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compact parser fixture loc info #11322
Compact parser fixture loc info #11322
Conversation
bd783c4
to
78af985
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very cool idea 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is dark magic
78af985
to
a93d80b
Compare
@nicolo-ribaudo CI is green now. 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
Another MX (Maintinaer Experience) PR.
When working on babel parser, the fixture is typically too long to skim. One of obstacles are the
loc
info occupies many lines. This PR compacts the fixtures a bit so now it should be easier to read the test fixtures.For example, see if you can read this fixture now: https://github.com/babel/babel/blob/bd783c4543d74ffa8f2a248ea449eda64d4fdf77/packages/babel-parser/test/fixtures/comments/basic/array-pattern-trailing-comma/output.json
Please review the first commit only as the whole diff turns out too large for GitHub.
The idea is stolen from the Flow repo.