Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine babel core types #11544

Merged
merged 6 commits into from Jun 21, 2020
Merged

Refine babel core types #11544

merged 6 commits into from Jun 21, 2020

Conversation

@JLHwung
Copy link
Contributor

JLHwung commented May 12, 2020

Q                       A
License MIT
  • Generally improved flow typings in @babel/core.
  • Enabled flow annotation on packages/babel-core/src/config/validation/plugins.js, which
    catches a bug introduced by #10402 where assertVisitorMap is not working as intended.

@codesandbox
Copy link

codesandbox bot commented May 12, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 369d237:

Sandbox Source
damp-cdn-u2rg6 Configuration
blazing-bird-u3jj5 Configuration
@babel-bot
Copy link
Collaborator

babel-bot commented May 12, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/23973/

@JLHwung JLHwung force-pushed the JLHwung:refine-babel-core-types branch from 01e9e44 to 369d237 Jun 15, 2020
@JLHwung JLHwung mentioned this pull request Jun 15, 2020
@JLHwung JLHwung changed the base branch from master to main Jun 19, 2020
@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Jun 21, 2020

I'm merging this with a single review, since it's mostly about internal typings.

@nicolo-ribaudo nicolo-ribaudo merged commit 601c824 into babel:main Jun 21, 2020
8 of 9 checks passed
8 of 9 checks passed
build
Details
test262 Workflow: test262
Details
Gitpod Open an online workspace in Gitpod
Details
Travis CI - Pull Request Build Passed
Details
babel/repl REPL preview is available
Details
build-standalone Workflow: build-standalone
Details
ci/codesandbox Building packages succeeded.
Details
codecov/project 91.83% (target 90.00%)
Details
e2e Workflow: e2e
Details
@nicolo-ribaudo nicolo-ribaudo deleted the JLHwung:refine-babel-core-types branch Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.