Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jsx parser missing plugins errors #11499 #11629

Closed
wants to merge 1 commit into from
Closed

Add jsx parser missing plugins errors #11499 #11629

wants to merge 1 commit into from

Conversation

iosh
Copy link

@iosh iosh commented May 27, 2020

Q                       A
Fixed Issues? #11499
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/22938/

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b135a6a:

Sandbox Source
falling-shadow-pwz3z Configuration
optimistic-sound-5mzn2 Configuration

@existentialism existentialism added pkg: parser PR: Polish 💅 A type of pull request used for our changelog categories labels May 27, 2020
@@ -0,0 +1,4 @@
{
"throws": "This experimental syntax requires enabling the parser plugin: 'jsx' (1:0)",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could throw this.expectOnePlugin(["jsx", "flow", "typescript"]) to give an error that is also correct in this case?

@iosh iosh closed this Jun 15, 2020
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Sep 15, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Polish 💅 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants