Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add decimal parsing support #11640

Merged
merged 10 commits into from Jul 29, 2020
Merged

Add decimal parsing support #11640

merged 10 commits into from Jul 29, 2020

Conversation

@JLHwung
Copy link
Contributor

JLHwung commented May 29, 2020

Q                       A
Fixed Issues? Closes tc39/proposal-decimal#18
Minor: New Feature? Yes
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Added initial parsing support on Decimal Proposal, e.g. 0.3m.

AST spec

  • parser support
  • generator support
  • create @babel/syntax-decimal
  • add to @babel/standalone
  • babel parser typings

@codesandbox
Copy link

codesandbox bot commented May 29, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3c84908:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration
@babel-bot
Copy link
Collaborator

babel-bot commented May 29, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/26230/

@JLHwung JLHwung marked this pull request as ready for review May 29, 2020
@JLHwung JLHwung force-pushed the JLHwung:decimal branch from b3a30d1 to c1a1090 May 30, 2020
@nicolo-ribaudo nicolo-ribaudo added this to the 7.11.0 milestone May 31, 2020
@nicolo-ribaudo nicolo-ribaudo self-requested a review May 31, 2020
@JLHwung JLHwung changed the base branch from master to main Jun 19, 2020
@JLHwung JLHwung force-pushed the JLHwung:decimal branch from c1a1090 to ac91d7b Jun 30, 2020
@JLHwung JLHwung force-pushed the JLHwung:decimal branch from ac91d7b to 49dd6d3 Jul 15, 2020
@JLHwung JLHwung force-pushed the JLHwung:decimal branch from 49dd6d3 to 3c84908 Jul 21, 2020
@hzoo
hzoo approved these changes Jul 27, 2020
@JLHwung JLHwung merged commit 059e912 into babel:main Jul 29, 2020
8 of 9 checks passed
8 of 9 checks passed
build
Details
test262-pr Workflow: test262-pr
Details
Gitpod Open an online workspace in Gitpod
Details
Travis CI - Pull Request Build Passed
Details
babel/repl REPL preview is available
Details
build-standalone Workflow: build-standalone
Details
ci/codesandbox Building packages succeeded.
Details
codecov/project 91.82% (target 90.00%)
Details
e2e Workflow: e2e
Details
@JLHwung JLHwung deleted the JLHwung:decimal branch Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.