Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update `spec-new` in CONTRIBUTING.md [skip ci] #11706

Merged
merged 4 commits into from Jul 17, 2020

Conversation

@JLHwung
Copy link
Contributor

JLHwung commented Jun 11, 2020

Q                       A
License MIT

This PR updates the process of developing a new babel plugin in this repo. It features a detailed checklist and an updated example of a new parser feature PR.

The process also requires an AST PR addressed in ESTree before implementation. By doing so we can gather more feedback, especially about the AST shape, before a new proposal is implemented in Babel. In the future we will follow ESTree unless the new AST is not consistent with current Babel AST.

/cc @nzakas @RReverser

@codesandbox

This comment was marked as off-topic.

@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Jun 11, 2020

In the future we will follow ESTree unless the new AST is not consistent with current Babel AST.

Also not if the experimental estree nodes change after that we implemented them (and they are free to do so).

@JLHwung
Copy link
Contributor Author

JLHwung commented Jun 11, 2020

@nicolo-ribaudo Though it is called experimental in ESTree, the AST changes are still rare once it gets approved: https://github.com/estree/estree/commits/master/experimental

We should document our AST stability policy somewhere. Here it works as a rough guideline to new contributors working on new language features.

@JLHwung JLHwung requested a review from hzoo Jun 18, 2020
@JLHwung JLHwung changed the base branch from master to main Jun 19, 2020
@JLHwung JLHwung force-pushed the JLHwung:update-new-plugin-contributing branch from 8b4baca to 54a954f Jul 16, 2020
@hzoo
hzoo approved these changes Jul 16, 2020
Copy link
Member

hzoo left a comment

Cool!

it would be nice to maybe document where/when we do things somewhere (I used to do it at https://github.com/babel/proposals, example like babel/proposals#18) so you can track history but it's been some work to keep it all organized/updated

CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-authored-by: Brian Ng <bng412@gmail.com>
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Member

existentialism left a comment

👍

JLHwung and others added 2 commits Jul 17, 2020
Co-authored-by: Brian Ng <bng412@gmail.com>
Co-authored-by: Brian Ng <bng412@gmail.com>
@JLHwung JLHwung merged commit 238cadd into babel:main Jul 17, 2020
5 of 6 checks passed
5 of 6 checks passed
build
Details
test262-pr Workflow: test262-pr
Details
build-standalone Workflow: build-standalone
Details
e2e Workflow: e2e
Details
Gitpod Open an online workspace in Gitpod
Details
ci/codesandbox Building packages succeeded.
Details
@JLHwung JLHwung deleted the JLHwung:update-new-plugin-contributing branch Jul 17, 2020
@JLHwung
Copy link
Contributor Author

JLHwung commented Jul 17, 2020

it would be nice to maybe document where/when we do things somewhere (I used to do it at https://github.com/babel/proposals, example like babel/proposals#18) so you can track history but it's been some work to keep it all organized/updated

Yeah a repo / issue tracking each proposals is always good-to-have but proves a bit overhead, at it is prone to become outdated compared to https://github.com/tc39/proposals.

Currently we use labels to track issues related to specific proposals. It is easier to maintain rather than updating stages/status manually in babel/proposals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.