Support private properties for semi rule #11748
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c10e795:
|
existentialism
added
area: eslint
PR: New Feature 🚀
| } | ||
| } | ||
| } | ||
|
|
||
| export default ruleComposer.joinReports([ | ||
| rule, | ||
| context => ({ | ||
| ClassProperty(node) { |
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes! As an example, you can see this core rule: https://github.com/eslint/eslint/blob/master/lib/rules/func-call-spacing.js#L171
We should be able to combine both of these selectors into one, e.g. "ClassProperty, ClassPrivateProperty"(node) {}.
There was a problem hiding this comment.
Good to know that A, B is supported, guess we should update https://eslint.org/docs/developer-guide/selectors#what-syntax-can-selectors-have.
Update: estools/esquery#113
| } | ||
| } | ||
| } | ||
|
|
||
| export default ruleComposer.joinReports([ | ||
| rule, | ||
| context => ({ | ||
| ClassProperty(node) { |
There was a problem hiding this comment.
Yes! As an example, you can see this core rule: https://github.com/eslint/eslint/blob/master/lib/rules/func-call-spacing.js#L171
We should be able to combine both of these selectors into one, e.g. "ClassProperty, ClassPrivateProperty"(node) {}.
github-actions
bot
added
the
outdated
Corresponding PR for eslint-plugin-babel repo: babel/eslint-plugin-babel#194 (comment)