Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace caniuse-db by mdn-browser-compat-data #11838

Merged
merged 2 commits into from Jul 20, 2020

Conversation

@JLHwung
Copy link
Contributor

JLHwung commented Jul 14, 2020

Q                       A
Patch: Bug Fix? es6.modules compat-data should include node: 13.2.
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

In this PR I have replaced caniuse-db by mdn-browser-compat-data when building the modules support in @babel/compat-data. The rationale here is

  • caniuse states that the support data of es6-modules are from mdn/browser-compat-data
  • I have submitted a PR for export * as ns support, which enables us to include export-namespace-from in the preset-env.
  • The mdn-browser-compat-data is easier to process than caniuse-db (no more getLowestImplementedVersions)
  • caniuse does not have nodejs support data

@codesandbox
Copy link

codesandbox bot commented Jul 14, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 842112b:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration
@babel-bot
Copy link
Collaborator

babel-bot commented Jul 14, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/26084/

@JLHwung JLHwung marked this pull request as draft Jul 14, 2020
@JLHwung JLHwung force-pushed the JLHwung:use-mdn-browser-compat-data branch from 8ed0873 to d15ce7d Jul 17, 2020
@JLHwung JLHwung marked this pull request as ready for review Jul 17, 2020
@JLHwung JLHwung force-pushed the JLHwung:use-mdn-browser-compat-data branch from d15ce7d to 842112b Jul 17, 2020
@JLHwung JLHwung requested a review from existentialism Jul 17, 2020
};
fs.writeFileSync(dataPath, `${JSON.stringify(data, null, 2)}\n`);
exports.process = process;

This comment has been minimized.

@nicolo-ribaudo

nicolo-ribaudo Jul 20, 2020 Member

What is this needed for?

@existentialism existentialism self-assigned this Jul 20, 2020
@JLHwung JLHwung merged commit 48be93b into babel:main Jul 20, 2020
8 of 9 checks passed
8 of 9 checks passed
build
Details
test262-pr Workflow: test262-pr
Details
Gitpod Open an online workspace in Gitpod
Details
Travis CI - Pull Request Build Passed
Details
babel/repl REPL preview is available
Details
build-standalone Workflow: build-standalone
Details
ci/codesandbox Building packages succeeded.
Details
codecov/project 91.85% (target 90.00%)
Details
e2e Workflow: e2e
Details
@JLHwung JLHwung deleted the JLHwung:use-mdn-browser-compat-data branch Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.