Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disallow \8, \9 in strict mode string #11852

Merged
merged 1 commit into from Jul 21, 2020

Conversation

@JLHwung
Copy link
Contributor

JLHwung commented Jul 20, 2020

Q                       A
Fixed Issues? babel/proposals#67 (comment)
Patch: Bug Fix? Yes
License MIT

I also rephrased the error message (copied from JSC).

@codesandbox
Copy link

codesandbox bot commented Jul 20, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit be8c5b2:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration
@babel-bot
Copy link
Collaborator

babel-bot commented Jul 20, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/26120/

@JLHwung JLHwung merged commit 2bf38fb into babel:main Jul 21, 2020
8 of 9 checks passed
8 of 9 checks passed
build
Details
test262-pr Workflow: test262-pr
Details
Gitpod Open an online workspace in Gitpod
Details
Travis CI - Pull Request Build Passed
Details
babel/repl REPL preview is available
Details
build-standalone Workflow: build-standalone
Details
ci/codesandbox Building packages succeeded.
Details
codecov/project 91.85% (target 90.00%)
Details
e2e Workflow: e2e
Details
@JLHwung JLHwung deleted the JLHwung:disallow-escape-89-in-strict-mode branch Jul 21, 2020
fisker added a commit to prettier/prettier that referenced this pull request Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.