Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move check for TSTypeCastExpression to catch another case #12161

Merged
merged 1 commit into from Oct 11, 2020

Conversation

@existentialism
Copy link
Member

@existentialism existentialism commented Oct 9, 2020

Q                       A
Fixed Issues? Fixes #12141
Patch: Bug Fix? Y
License MIT

@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented Oct 9, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/29726/

@codesandbox
Copy link

@codesandbox codesandbox bot commented Oct 9, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d198f6e:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration
@existentialism existentialism force-pushed the print-typecastexpression branch from 68b101f to d198f6e Oct 9, 2020
@JLHwung
JLHwung approved these changes Oct 9, 2020
@nicolo-ribaudo nicolo-ribaudo merged commit 13a1cfd into main Oct 11, 2020
25 of 26 checks passed
25 of 26 checks passed
Prepare Cache
Details
Prepare Cache
Details
Test on Node.js Latest
Details
Test on Node.js Latest
Details
Build Babel Artifacts
Details
Build Babel Artifacts
Details
Test on Node.js (13)
Details
Test on Node.js (13)
Details
Test on Node.js (12)
Details
Test on Node.js (12)
Details
Test on Node.js (10)
Details
Test on Node.js (10)
Details
Test on Node.js (8)
Details
Test on Node.js (8)
Details
Test on Node.js (6)
Details
Test on Node.js (6)
Details
test262-pr Workflow: test262-pr
Details
Gitpod Open an online workspace in Gitpod
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
babel/repl REPL preview is available
Details
build-standalone Workflow: build-standalone
Details
ci/codesandbox Building packages succeeded.
Details
codecov/project Codecov Report
Details
codecov/project 91.75% (target 90.00%)
Details
e2e Workflow: e2e
Details
@nicolo-ribaudo nicolo-ribaudo deleted the print-typecastexpression branch Oct 11, 2020
@fisker fisker mentioned this pull request Oct 15, 2020
3 of 3 tasks complete
sosukesuzuki added a commit to sosukesuzuki/prettier that referenced this pull request Oct 15, 2020
sosukesuzuki added a commit to prettier/prettier that referenced this pull request Oct 20, 2020
* Install babel/parser 7.12

* Add tests for babel/babel#12161

* Add test for babel/babel#12076

* Add test for babel/babel#12085

* Add test for babel/babel#12108

* Add test for babel/babel#12120

* Add test for babel/babel#12054

* Add test for babel/babel#12061

* Add test babel/babel#12093

* Add test for babel/babel#12065

* Add test for babel/babel#12111

* Add test for babel/babel#12072

* Switch syntax-module-attributes to syntax-import-assertion

* Support "String import/export specifier"

* Remove tests for module-attributes

* Add changelog

* Update to 7.12.3

* Fix by linter

* Fix by spellchecker

* Add tests for module attributes to errors

* Add error test for module string name with import

* Remove TSTypeCastExpression

* Add tests for funny import-assertions

* Update snapshots|

* Add more tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.