Mark ThisExpression and Super as Purish
#12251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The other purish types are functions and literals, so I guess it means "it doesn't have side effects"
nicolo-ribaudo
added
the
PR: Internal 🏠
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/31175/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f962a32:
|
JLHwung
reviewed
Oct 26, 2020
| @@ -980,7 +980,7 @@ defineType("SwitchStatement", { | |||
| }); | |||
|
|
|||
| defineType("ThisExpression", { | |||
| aliases: ["Expression"], | |||
| aliases: ["Expression", "Pureish"], | |||
There was a problem hiding this comment.
Can you add a test in packages/babel-traverse/test/scope.js?
JLHwung
approved these changes
Oct 26, 2020
nicolo-ribaudo
changed the title
ThisExpression as PurishThisExpression and Super as Purish
existentialism
approved these changes
Oct 27, 2020
nicolo-ribaudo
added a commit
that referenced
this pull request
Nov 4, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
Pureishwas used for literals and for functions, so it means "something that doesn't have side-effects when evaluated".This has the effect of returning
truefrompath.isPure()for this, potentially removingthiswhen it's not used in some transforms.Extracted from #12250.