Use chokidar@2 without fsevents@1 in @babel/cli
#12322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: Internal 
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/31924/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b807c4b:
|
|
The failing tests are fixed by #12323 |
nicolo-ribaudo
force-pushed
the
fsevents-warning
branch
from
fd9a3c1
to
b807c4b
Compare
JLHwung
approved these changes
Nov 7, 2020
|
Yeah, chokidar was definitely the most wanted change for Babel 8 |
existentialism
approved these changes
Nov 10, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
If
fseventsis not available,chokidarshould fallback to fs polling by default. Sincefseventsis never going to be available now that the binaries aren't hoisted anymore, we can remove it from our deps avoiding thenode-gyperror for MacOS users.Can someone with MacOS confirm that with this PR,
babel --watchstill works on Node.js 6?