Run e2e tests on GH actions #12517
Run e2e tests on GH actions #12517
Conversation
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/44268/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4c86b80:
|
|
You mentioned you were using the httpassw file, I'm not sure whether you wants to use it, I'd use for CI https://github.com/verdaccio/monorepo/tree/9.x/plugins/auth-memory#verdaccio-auth-memory which does not require write anything also speed up things a bit. |
|
Thanks, I'm trying that now. |
|
I'll take a look over this weekend to this, let's see whether I find something. |
|
Ok fixed 👍 , I've spotted few little mistakes, @nicolo-ribaudo do you mind if I PR on top of this one? I'd like to apply few optimizations.
|
|
Changes are here https://github.com/juanpicado/babel/pull/1/files |
|
Hey sorry I completely forgot about this. I'll merge your branch into mine! |
|
Sure, just let me know if you need some help, I'll be willing to move this on. |
nicolo-ribaudo
force-pushed
the
e2e-gh-actions
branch
10 times, most recently
from
7d5d057
to
463a951
Compare
nicolo-ribaudo
force-pushed
the
e2e-gh-actions
branch
from
463a951
to
76195b9
Compare
nicolo-ribaudo
force-pushed
the
e2e-gh-actions
branch
from
6e6aafe
to
519e9ab
Compare
| @@ -3,14 +3,14 @@ | |||
| # Copied from https://github.com/facebook/create-react-app/blob/053f9774d3f592c17741d2a86de66a7ca58f90c0/tasks/local-registry.sh | |||
|
|
|||
| custom_registry_url=http://localhost:4873 | |||
| default_verdaccio_package=verdaccio@~4.3.3 | |||
| default_verdaccio_package=verdaccio@~4.10.0 | |||
There was a problem hiding this comment.
I think is better v4.11.1, it has few optimizations.
|
|
||
| function startLocalRegistry { | ||
| # Start local registry | ||
| tmp_registry_log=`mktemp` | ||
| echo "Registry output file: $tmp_registry_log" | ||
| (cd && nohup npx ${VERDACCIO_PACKAGE:-$default_verdaccio_package} -c $1 &>$tmp_registry_log &) | ||
|
|
||
| npm install --global verdaccio-memory |
There was a problem hiding this comment.
I'd pin verdaccio-memory@9.7.2 . There are few major coming soon that might affect the pipeline.
| @@ -20,6 +20,10 @@ auth: | |||
| uplinks: | |||
| npmjs: | |||
| url: https://registry.npmjs.org/ | |||
| agent_options: | |||
There was a problem hiding this comment.
The agent_options are not need it if you use (v4.10.0). It is harmless if you like to keep it.
| @@ -54,7 +58,7 @@ middlewares: | |||
|
|
|||
| # log settings | |||
| logs: | |||
| - { type: stdout, format: pretty, level: http } | |||
| - { type: stdout, format: pretty, level: trace } | |||
There was a problem hiding this comment.
I'd move here to warn to speed boost. trace is really expensive.
Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>
|
I'm merging even if one review is from @juanpicado and not from a Babel team member, since he definitely has more experience than us with Verdaccio on CI servers 😛 |
github-actions
bot
added
the
outdated
CircleCI is quite slow because there is a low concurrency limit (I think it's 1 job at time?) so it gets overloaded easily and sometimes jobs are queued for hours. Even when they are not, it happens quite often that they wait for ~30 mins before running.
This PR moves the Babel 7 e2e tests to GitHub actions, where the concurrency limit is 16 parallel jobs, to speed it up a bit.
I'm not moving everything to GH actions to avoid hitting the concurrency limit. CircleCI will still run:
build-standaloneon PRs andmaine2e-breakingonmain(it's opt-in on PRs)test262onmain(it's opt-in on PRs)Thanks @juanpicado for the help!