Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: reuse lodash library within eslint tests #12640

Merged
merged 1 commit into from Jan 18, 2021
Merged

test: reuse lodash library within eslint tests #12640

merged 1 commit into from Jan 18, 2021

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Jan 17, 2021 •
edited by gitpod-io bot

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change? no
Minor: New Feature? no
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes? Yes, dev
License MIT

Reuse lodash package within eslint tests instead of installing per package modules,
https://lodash.com/per-method-packages

However, use of these packages is discouraged and they will be removed in v5.

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/37675/

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0f46034:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

JLHwung
JLHwung approved these changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@existentialism existentialism added PR: Internal 🏠 A type of pull request used for our changelog categories area: tests labels Jan 18, 2021
@existentialism existentialism merged commit 53f9fcd into babel:main Jan 18, 2021
@armano2 armano2 deleted the test/lodash branch January 18, 2021 16:50
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Apr 20, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

Assignees
No one assigned
Labels
area: tests outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@armano2 @babel-bot @JLHwung @existentialism