Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[babel-cli] Don't fail when chmod throws an error #12846

Merged
merged 4 commits into from Feb 22, 2021
Merged

[babel-cli] Don't fail when chmod throws an error #12846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fa7e0ab
[12835] Added try/catch to babel-cli chmod
immitsu Feb 22, 2021
ea48568
Update packages/babel-cli/src/babel/util.js
immitsu Feb 22, 2021
9daf934
[12835] Added test forr chmod fails
immitsu Feb 22, 2021
68e573a
Update packages/babel-cli/test/index.js
immitsu Feb 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/babel-cli/src/babel/util.js
View file
Open in desktop
Expand Up @@ -6,7 +6,11 @@ import path from "path";
import fs from "fs";

export function chmod(src: string, dest: string): void {
fs.chmodSync(dest, fs.statSync(src).mode);
try {
fs.chmodSync(dest, fs.statSync(src).mode);
} catch (err) {
console.warn(`Cannot change permissions of ${dest}`);
}
}

type ReaddirFilter = (filename: string) => boolean;
Expand Down
13 changes: 13 additions & 0 deletions packages/babel-cli/test/index.js
View file
Open in desktop
Expand Up @@ -7,6 +7,7 @@ const escapeRegExp = require("lodash/escapeRegExp");
const merge = require("lodash/merge");
const path = require("path");
const fs = require("fs");
const { chmod } = require("../lib/babel/util");

const fixtureLoc = path.join(__dirname, "fixtures");
const tmpLoc = path.join(__dirname, "tmp");
Expand Down Expand Up @@ -269,3 +270,15 @@ fs.readdirSync(fixtureLoc).forEach(function (binName) {
});
});
});

describe("util.js", () => {
describe("chmod", () => {
it("should warn the user if chmod fails", () => {
const spyConsoleWarn = jest.spyOn(console, "warn");
// should expect a string as first argument
chmod(100, "file.js");
expect(spyConsoleWarn).toHaveBeenCalledTimes(1);
spyConsoleWarn.mockRestore();
});
});
});