fix(traverse): set the correct context when getting multiple NodePath

[fedeci]

Q	A
Fixed Issues?	Fixes #12570
Patch: Bug Fix?	Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass?	Yes
Documentation PR Link
Any Dependency Changes?
License	MIT

[babel-bot]

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/47769/

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c7db2a6:

Sandbox	Source
babel-repl-custom-plugin	Configuration
babel-plugin-multi-config	Configuration

[nicolo-ribaudo]

Could you check if this also fixes #12631, which is another context-related bug?

[fedeci]

I applied the same changes to node_modules/ of the reproduction repo and it didn't work.

[JLHwung]

I think v.context should be supplied as a fallback of context.

[fedeci]

Here the context defaults to true, so if no specific context is passed it will be used the one of the current NodePath (It may not be the right one).
Because of this we can't fallback since context is always defined when calling #get().

babel/packages/babel-traverse/src/path/family.ts

Lines 188 to 202 in 468a43c

	function get<T extends t.Node>(
	this: NodePath<T>,
	key: string,
	context: true | TraversalContext = true,
	): NodePath | NodePath[] {
	if (context === true) context = this.context;
	const parts = key.split(".");
	if (parts.length === 1) {
	// "foo"
	return this._getKey(key, context);
	} else {
	// "foo.bar"
	return this._getPattern(parts, context);
	}
	}

[JLHwung]

In this case we can use v.context when context is true, otherwise when a context is indeed passed as TraversalContext, we should respect the input, though.

[fedeci]

Just a couple questions.
Since this method is only called from #get() this shouldn't be marked as optional because it will default to true when no value is provided. Right?

Also this is not expected to be called from third party plugins, then it shouldn't be exported?

[fedeci]

The same for this.

[JLHwung]

v.context is always undefined because v is a Node not a NodePath.