Correctly update module.exports.default of typeof helper
#12858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolo-ribaudo
commented
Feb 23, 2021
nicolo-ribaudo
commented
| Q | A |
|---|---|
| Fixed Issues? | Fixes strapi/strapi#9482, |
| Patch: Bug Fix? | |
| Major: Breaking Change? | |
| Minor: New Feature? | |
| Tests Added + Pass? | Yes |
| Documentation PR Link | |
| Any Dependency Changes? | |
| License | MIT |
nicolo-ribaudo
commented
Feb 23, 2021
| return typeof obj; | ||
| }; | ||
|
|
||
| module.exports["default"] = module.exports, module.exports.__esModule = true; |
There was a problem hiding this comment.
The bug is fixed by this line.
JLHwung
changed the title
nicolo-ribaudo
changed the title
module.exports.default of typeof helper
hzoo
approved these changes
Feb 23, 2021
JLHwung
approved these changes
Feb 23, 2021
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 02b674c:
|
|
I can confirm this fixes the strapi issue, I can successfully create and run a new project. |
nicolo-ribaudo
added
i: regression
PR: Bug Fix 🐛
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/41998/ |
This was referenced Mar 15, 2021
build(deps): bump @babel/plugin-proposal-decorators from 7.10.5 to 7.13.5
ChatterlyOSE/Chatterly#594
Closed
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.