Fix a bug with invalid print output when empty array is passed to t.tsInterfaceDeclaration #12921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/43107/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 775544e:
|
saitonakamura
force-pushed
the
fixed-empty-extends-print-when-empty-array
branch
from
8bd104f
to
92d12b8
Compare
|
Could you add a test in https://github.com/babel/babel/blob/main/packages/babel-generator/test/index.js? 🙏 |
nicolo-ribaudo
added
pkg: generator
PR: Bug Fix 🐛
…sInterfaceDeclaration
If you pass an empty array as `extends` in `t.tsInterfaceDeclaration` you'll get an invalid code printed
```ts
t.tsInterfaceDeclaration(
t.identifier('x'),
undefined,
[],
t.tsInterfaceBody([])
)
```
You will get
```ts
interface A extends {}
```
Which is an invalid TS, this PR fixes that
saitonakamura
force-pushed
the
fixed-empty-extends-print-when-empty-array
branch
from
92d12b8
to
775544e
Compare
|
Ya, totally, hope it's in the right place 😄 |
nicolo-ribaudo
approved these changes
Feb 28, 2021
This was referenced Mar 5, 2021
Closed
Closed
Closed
This was referenced Mar 17, 2021
Closed
Merged
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug with invalid print output when empty array is passed to t.tsInterfaceDeclaration
If you pass an empty array as
extendsint.tsInterfaceDeclarationyou'll get an invalid code printedYou will get
Which is an invalid TS, this PR fixes that