convert @babel/helper-fixtures to typescript #12922
Conversation
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/43100/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4ae0c3a:
|
nicolo-ribaudo
added
the
Flow -> TS
| @@ -119,7 +122,7 @@ function pushTask(taskName, taskDir, suite, suiteName) { | |||
| const taskOptsLoc = tryResolve(taskDir + "/options"); | |||
| if (taskOptsLoc) Object.assign(taskOpts, require(taskOptsLoc)); | |||
|
|
|||
| const test = { | |||
| const test: any = { | |||
There was a problem hiding this comment.
Doesn't TS infer the correct type here?
There was a problem hiding this comment.
it does, but there are additional properties assigned later(sourceMappings, sourceMap, inputSourceMap)
other options would be - restructure the code to construct test with all properties in it, or to have type for it separately
There was a problem hiding this comment.
made a bit better fix instead of any
|
I'm merging this as a single commit (not rename + convert) because git is correctly tracking renamed files. |
github-actions
bot
added
the
outdated
@babel/helper-fixtures part of #11578