convert @babel/helper-module-transforms to typescript #12928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 22f8ab4:
|
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/44809/ |
nicolo-ribaudo
added
the
Flow -> TS
zxbodya
force-pushed
the
ts-migration/babel-helper-module-transforms
branch
from
7b668b4
to
a34bb9d
Compare
zxbodya
force-pushed
the
ts-migration/babel-helper-module-transforms
branch
from
a34bb9d
to
bdb2c24
Compare
JLHwung
reviewed
Mar 18, 2021
| @@ -280,7 +284,9 @@ function getModuleMetadata( | |||
| data.reexports.set(exportName, importName); | |||
|
|
|||
| if (exportName === "__esModule") { | |||
| throw exportName.buildCodeFrameError('Illegal export "__esModule".'); | |||
| throw spec | |||
| .get("exported") | |||
There was a problem hiding this comment.
Good catch from type checking!
JLHwung
reviewed
Mar 18, 2021
| @@ -68,7 +93,7 @@ export default function rewriteLiveReferences( | |||
| return identNode; | |||
| } | |||
|
|
|||
| let namespace = t.identifier(meta.name); | |||
| let namespace: t.Expression = t.identifier(meta.name); | |||
There was a problem hiding this comment.
Q: why we need to annotation namespace is an expression here?
There was a problem hiding this comment.
if not adding annotation type is inferred as t.Idendifier, but it might be is reassigned later to t.CallExpression which will cause an error
JLHwung
approved these changes
Mar 18, 2021
nicolo-ribaudo
force-pushed
the
ts-migration/babel-helper-module-transforms
branch
from
bdb2c24
to
fd4ce34
Compare
nicolo-ribaudo
approved these changes
Mar 27, 2021
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@babel/helper-module-transforms part of #11578