Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not bail on SHOW_CONFIG_FOR matches #12954

Merged
merged 6 commits into from Mar 23, 2021
Merged

Do not bail on SHOW_CONFIG_FOR matches #12954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2ef3acf
fix: do not bail out on showConfig output
JLHwung Mar 2, 2021
74acc83
chore: update test fixtures
JLHwung Mar 2, 2021
bad56f7
update Windows test fixtures
JLHwung Mar 2, 2021
51b1c22
add config end marker
JLHwung Mar 2, 2021
44f8fb0
Update fixtures (Windows)
babel-bot Mar 2, 2021
46b622e
update windows artifacts again
JLHwung Mar 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions ...i/test/fixtures/babel/env - SHOW_CONFIG_FOR with multiple files-windows/out-files/test.js
View file
Open in desktop
@@ -1 +1,2 @@
"use strict";
"use strict";
1 change: 1 addition & 0 deletions ...abel-cli/test/fixtures/babel/env - SHOW_CONFIG_FOR with multiple files-windows/stdout.txt
View file
Open in desktop
Expand Up @@ -29,3 +29,4 @@ programmatic options from @babel/cli
},
"filename": "src//foo.js"
}
-----End Babel configs-----
1 change: 1 addition & 0 deletions ...babel-cli/test/fixtures/babel/env - SHOW_CONFIG_FOR with multiple files/out-files/test.js
View file
Open in desktop
@@ -1 +1,2 @@
"use strict";
"use strict";
1 change: 1 addition & 0 deletions packages/babel-cli/test/fixtures/babel/env - SHOW_CONFIG_FOR with multiple files/stdout.txt
View file
Open in desktop
Expand Up @@ -29,3 +29,4 @@ programmatic options from @babel/cli
},
"filename": "src/foo.js"
}
-----End Babel configs-----
1 change: 1 addition & 0 deletions packages/babel-cli/test/fixtures/babel/env - SHOW_CONFIG_FOR-windows/out-files/lib/foo.js
View file
Open in desktop
@@ -0,0 +1 @@
"use strict";
3 changes: 2 additions & 1 deletion packages/babel-cli/test/fixtures/babel/env - SHOW_CONFIG_FOR-windows/stdout.txt
View file
Open in desktop
Expand Up @@ -29,4 +29,5 @@ programmatic options from @babel/cli
},
"filename": "src//foo.js"
}
Successfully compiled 1 file with Babel (123ms).
-----End Babel configs-----
Successfully compiled 2 files with Babel (123ms).
1 change: 0 additions & 1 deletion packages/babel-cli/test/fixtures/babel/env - SHOW_CONFIG_FOR/in-files/my-extended.js
View file
Open in desktop
Expand Up @@ -11,7 +11,6 @@ module.exports = {
"@foo/babel-preset-1",
[
{
name: "@foo/inline-babel-preset-1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: What is this change needed for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Babel will throw name is not a valid option. I didn't know name is forbidden on preset until now. 🤦‍♂️

plugins: [
{
name: "@foo/inline-babel-plugin-1",
Expand Down
3 changes: 1 addition & 2 deletions ...t/fixtures/babel/env - SHOW_CONFIG_FOR/in-files/node_modules/@foo/babel-preset-1/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions ...t/fixtures/babel/env - SHOW_CONFIG_FOR/in-files/node_modules/@foo/babel-preset-2/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions ...t/fixtures/babel/env - SHOW_CONFIG_FOR/in-files/node_modules/@foo/babel-preset-3/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions ...t/fixtures/babel/env - SHOW_CONFIG_FOR/in-files/node_modules/@foo/babel-preset-4/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion packages/babel-cli/test/fixtures/babel/env - SHOW_CONFIG_FOR/stdout.txt
View file
Open in desktop
Expand Up @@ -39,7 +39,6 @@ config <CWD>/my-extended.js .overrides[0].env["test"]
"@foo/babel-preset-1",
[
{
"name": "@foo/inline-babel-preset-1",
"plugins": [
{
"name": "@foo/inline-babel-plugin-1",
Expand Down Expand Up @@ -125,3 +124,5 @@ programmatic options from @babel/cli
},
"filename": "./src/index.js"
}
-----End Babel configs-----
"use strict";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should print a separator between the code and the config? Something like


================================================================================

As an alternative, maybe it would be better to print the config on stderr so that it doesn't breaks things such as

cat input.js | babel --config-file ./babel.config.json > output.js

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the debug output should be directed to stderr.

For example curl -v http://example.com/example.avif > example.avif will also break, unless we specify -O example.avif. Similary in this case, consider use --out-file example.js instead.

4 changes: 2 additions & 2 deletions packages/babel-core/src/config/config-chain.js
View file
Open in desktop
Expand Up @@ -261,9 +261,9 @@ export function* buildRootChain(
// print config by the order of ascending priority
[configReport, babelRcReport, programmaticReport]
.filter(x => !!x)
.join("\n\n"),
.join("\n\n") +
"\n-----End Babel configs-----",
);
return null;
}
// Insert file chain in front so programmatic options have priority
// over configuration file chain items.
Expand Down