refactor: avoid parsing logic on locations #13200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
PR: Internal 🏠
JLHwung
commented
Apr 24, 2021
| const moduloPos = this.state.start; | ||
| this.expect(tt.modulo); | ||
| const checksLoc = this.state.startLoc; | ||
| this.next(); // eat `%` |
There was a problem hiding this comment.
flowParsePredicate is always guarded by this.match(tt.modulo).
JLHwung
force-pushed
the
avoid-parsing-logic-on-loc
branch
from
4f50d09
to
ada1a64
Compare
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/45550/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ada1a64:
|
jridgewell
approved these changes
Apr 24, 2021
nicolo-ribaudo
approved these changes
Apr 24, 2021
kaicataldo
approved these changes
Apr 24, 2021
existentialism
approved these changes
Apr 25, 2021
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
locationsI plan to introduce
locations: booleanin@babel/parserand default it tofalsein Babel 8. This PR is the first step to ensure we do not rely on locations in parsing logic.