Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(parser): [Babel8] Align error codes between Flow and TypeScript #13294

Merged
merged 3 commits into from Aug 28, 2021
Merged

fix(parser): [Babel8] Align error codes between Flow and TypeScript #13294

merged 3 commits into from Aug 28, 2021

Conversation

sosukesuzuki
Copy link
Member

@sosukesuzuki sosukesuzuki commented May 11, 2021 •
edited by gitpod-io bot

Q                       A
Fixed Issues? N
Patch: Bug Fix? Y
Tests Added + Pass? Yes
License MIT

Errors with exactly the same message had different error codes, so align them.

@babel-bot
Copy link
Collaborator

babel-bot commented May 11, 2021 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/48324/

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 11, 2021 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5adf815:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

existentialism
existentialism previously approved these changes May 11, 2021
View reviewed changes
@JLHwung
Copy link
Contributor

JLHwung commented May 11, 2021 •
edited

The error code error.reasonCode is now part of API observable to users, I am afraid we can't ship this until next major release. We could add compatibility fallback in makeErrorTemplates and implement it behind process.env.BABEL_8_BREAKING.

@existentialism existentialism dismissed their stale review May 11, 2021 19:40

Forgot about how reasonCode's were constructed

@sosukesuzuki
Copy link
Member Author

Oh Okay, I'll fix

@sosukesuzuki sosukesuzuki changed the title parser: Align error codes between Flow and TypeScript fix(parser): [Babel8] Align error codes between Flow and TypeScript Aug 27, 2021
@sosukesuzuki
Copy link
Member Author

I had forgotten that this PR existed. I've pushed commits to address reviewed points now.

@JLHwung JLHwung mentioned this pull request Aug 27, 2021
Open
34 tasks
@sosukesuzuki
Copy link
Member Author

Can I merge this now?

@sosukesuzuki sosukesuzuki merged commit 64d116b into babel:main Aug 28, 2021
@sosukesuzuki sosukesuzuki deleted the align-error-codes branch August 28, 2021 15:13
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 28, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2021
@nicolo-ribaudo nicolo-ribaudo added this to the v8.0.0 milestone Aug 8, 2023
@nicolo-ribaudo nicolo-ribaudo added PR: Internal (next major) 🏠 A type of pull request used for our changelog categories for next major release and removed babel 8 labels Aug 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@fedeci fedeci fedeci approved these changes

@existentialism existentialism existentialism left review comments

Assignees
No one assigned
Labels
area: errors area: flow area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Internal (next major) 🏠 A type of pull request used for our changelog categories for next major release
Projects
None yet
Milestone
v8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sosukesuzuki @babel-bot @JLHwung @existentialism @fedeci @nicolo-ribaudo