Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test262 #13347

Merged
merged 2 commits into from May 21, 2021
Merged

Update test262 #13347

merged 2 commits into from May 21, 2021

Conversation

babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented May 21, 2021 •
edited by gitpod-io bot

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 21, 2021 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8e91dee:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot
Copy link
Collaborator Author

babel-bot commented May 21, 2021 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/46356/

nicolo-ribaudo
nicolo-ribaudo reviewed May 21, 2021
View reviewed changes
scripts/parser-tests/test262/allowlist.txt
@@ -1 +1,16 @@

language/module-code/import-assertion-key-identifiername.js(default)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There tests fail because we currently throw The only accepted module attribute is type`. We might want to relax that restriction.

JLHwung
JLHwung approved these changes May 21, 2021
View reviewed changes
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI error is not related.

@JLHwung JLHwung merged commit 82a2ca8 into main May 21, 2021
@JLHwung JLHwung deleted the update-test262-parser branch May 21, 2021 14:40
@JLHwung JLHwung mentioned this pull request Jun 1, 2021
Merged
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Aug 21, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo left review comments

@existentialism existentialism existentialism approved these changes

@JLHwung JLHwung JLHwung approved these changes

Assignees
No one assigned
Labels
area: test262 outdated A closed issue/PR that is archived due to age. Recommended to make a new issue repo automation 🤖
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@babel-bot @existentialism @JLHwung @nicolo-ribaudo