Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disallow computed async/get/set keyword #13531

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Jul 5, 2021

Q                       A
Fixed Issues? Babel should throw on class A { [get] a() {} }. REPL
Patch: Bug Fix? Y
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@JLHwung JLHwung added PR: Spec Compliance 👓 A type of pull request used for our changelog categories pkg: parser labels Jul 5, 2021
@babel-bot
Copy link
Collaborator

babel-bot commented Jul 5, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/47204/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 5, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b44ba55:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

fedeci
fedeci approved these changes Jul 5, 2021
@nicolo-ribaudo nicolo-ribaudo changed the title fix: disallow computed async/set keyword fix: disallow computed async/get/set keyword Jul 6, 2021
@nicolo-ribaudo nicolo-ribaudo merged commit bfd2f8f into babel:main Jul 6, 2021
25 of 27 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the disallow-computed-get-async-keyword-in-class-method branch Jul 6, 2021
nicolo-ribaudo pushed a commit to nicolo-ribaudo/babel that referenced this pull request Jul 30, 2021
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Spec Compliance 👓 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants