Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support hack pipeline in @babel/standalone #13555

Merged

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Jul 14, 2021

Q                       A
Fixed Issues? Support hack pipeline proposal in standalone
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature? Yes
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Due to conflict with record and tuple. Only % topic token is currently supported.

Supports hack pipeline and topic token. The topic token defaults to % since recordAndTupleSyntax defaults to hash.

REPL Preview

@JLHwung JLHwung added PR: New Feature 🚀 A type of pull request used for our changelog categories pkg: standalone labels Jul 14, 2021
@babel-bot
Copy link
Collaborator

babel-bot commented Jul 14, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/47437/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 14, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2badce1:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@JLHwung
Copy link
Contributor Author

JLHwung commented Jul 14, 2021

The CI error is fixed in #13536, will rebase after that one gets merged.

@nicolo-ribaudo
Copy link
Member

You should still be able to use # in hack pipes with {| and [| for R&T.

@nicolo-ribaudo nicolo-ribaudo added this to the v7.15.0 milestone Jul 22, 2021
@nicolo-ribaudo nicolo-ribaudo requested a review from hzoo July 26, 2021 15:44
@nicolo-ribaudo nicolo-ribaudo changed the title feat: support hack pipeline in babel-standalone feat: support hack pipeline in @babel/standalone Jul 28, 2021
@nicolo-ribaudo nicolo-ribaudo merged commit 81af5a7 into babel:feat-7.15.0/hack-pipes Jul 28, 2021
@nicolo-ribaudo nicolo-ribaudo deleted the standalone-topic-token branch July 28, 2021 19:45
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 7, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: standalone PR: New Feature 🚀 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants